Skip to content

Bug fix for model adapter - google#50

Merged
cemde merged 1 commit intomainfrom
fix/interface/google-response-model
Mar 23, 2026
Merged

Bug fix for model adapter - google#50
cemde merged 1 commit intomainfrom
fix/interface/google-response-model

Conversation

@cemde
Copy link
Collaborator

@cemde cemde commented Mar 23, 2026

Description

A bug in the google model adapter prevented runtime config to be passed ot the model client.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement (refactoring, formatting, etc.)

Checklist

Contribution

Documentation

  • Added/updated docstrings for new/modified functions as instructed CONTRIBUTING.md
  • Updated relevant documentation in docs/ (if applicable)
  • Tag github issue with this PR (if applicable)

Changelog

  • Added entry to CHANGELOG.md under [Unreleased] section
    • Use Added section for new features
    • Use Changed section for modifications to existing functionality
    • Use Fixed section for bug fixes
    • Use Removed section for deprecated/removed features
  • OR this is a documentation-only change (no changelog needed)

Example:
- Support for multi-agent tracing (PR:#123)

Architecture (if applicable)

  • Core/Interface separation: Changes in maseval/core/ do NOT import from maseval/interface/
  • Dependencies: New core dependencies added sparingly; framework integrations go to optional dependencies

Additional Notes

@cemde cemde added the bug Something isn't working label Mar 23, 2026
@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  maseval/interface/inference
  google_genai.py 355
Project Total  

This report was generated by python-coverage-comment-action

@cemde cemde marked this pull request as ready for review March 23, 2026 12:30
@cemde cemde merged commit 8641a10 into main Mar 23, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant