Skip to content

ENH: Make pd.to_datetime with format parameter more robust to dirty data (#62840) #63171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

ENH: Make pd.to_datetime with format parameter more robust to dirty data (#62840) #63171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a4c7eae
Initial tests
jakechirsch Nov 13, 2025
523b15c
Year parsing and added tests
jakechirsch Nov 19, 2025
18f0afd
Increased robustness -- full parsing
jakechirsch Nov 21, 2025
491f1bf
Fixed problem with dates with no ymd separator
jakechirsch Nov 21, 2025
5d2307d
Fixed minor month parsing bug with wrong goto
jakechirsch Nov 21, 2025
b2aa0b6
Fixed incorrect parsing bug when T separates date and time
jakechirsch Nov 21, 2025
1b840ca
Documentation update
jakechirsch Nov 21, 2025
0ff86d6
Edge case: threshold outside of [0.0, 1.0]
jakechirsch Nov 21, 2025
7f85dd7
Minor documentation update
jakechirsch Nov 21, 2025
721957b
Fixed hms parsing with no separator
jakechirsch Nov 25, 2025
6e44ba2
Documentation fixes
jakechirsch Nov 25, 2025
3c339b7
Fixed stub
jakechirsch Nov 25, 2025
8391b6f
Fixed parsing with timezone and no hms
jakechirsch Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pandas/_libs/include/pandas/datetime/pd_datetime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ typedef struct {
PyArray_DatetimeMetaData (*get_datetime_metadata_from_dtype)(PyArray_Descr *);
int (*parse_iso_8601_datetime)(const char *, int, int, npy_datetimestruct *,
NPY_DATETIMEUNIT *, int *, int *, const char *,
int, FormatRequirement);
int, FormatRequirement, double);
int (*get_datetime_iso_8601_strlen)(int, NPY_DATETIMEUNIT);
int (*make_iso_8601_datetime)(npy_datetimestruct *, char *, size_t, int,
NPY_DATETIMEUNIT);
Expand Down Expand Up @@ -94,10 +94,11 @@ static PandasDateTime_CAPI *PandasDateTimeAPI = NULL;
PandasDateTimeAPI->get_datetime_metadata_from_dtype((dtype))
#define parse_iso_8601_datetime(str, len, want_exc, out, out_bestunit, \
out_local, out_tzoffset, format, format_len, \
format_requirement) \
format_requirement, threshold) \
PandasDateTimeAPI->parse_iso_8601_datetime( \
(str), (len), (want_exc), (out), (out_bestunit), (out_local), \
(out_tzoffset), (format), (format_len), (format_requirement))
(out_tzoffset), (format), (format_len), (format_requirement), \
(threshold))
#define get_datetime_iso_8601_strlen(local, base) \
PandasDateTimeAPI->get_datetime_iso_8601_strlen((local), (base))
#define make_iso_8601_datetime(dts, outstr, outlen, utc, base) \
Expand Down
3 changes: 2 additions & 1 deletion pandas/_libs/include/pandas/vendored/numpy/datetime/np_datetime_strings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ int parse_iso_8601_datetime(const char *str, int len, int want_exc,
NPY_DATETIMEUNIT *out_bestunit, int *out_local,
int *out_tzoffset, const char *format,
int format_len,
FormatRequirement format_requirement);
FormatRequirement format_requirement,
double threshold);

/*
* Provides a string length to use for converting datetime
Expand Down
Loading
Loading