Fix json normalize 'meta' validation #63136
Open
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nocoding03
changed the title
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Updated the _validate_meta function to accept a string or a list of strings/lists of strings as input.
Author
|
@rhshadrach could you please take a look at this PR？ |
rhshadrach
reviewed
Nov 18, 2025
rhshadrach
requested changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Looking good! It seems to me the meta argument is not expected to be large data (e.g. hundreds of entries) and so these instance checks are okay. Also it seems questionable to me whether this should go through deprecation. I'd like another eye here - cc @mroeschke
Removed tests for non-string meta in json_normalize.
2 tasks
mroeschke
reviewed
Nov 25, 2025
Comment on lines
+471
to
+472
| if meta is not None: | ||
| _validate_meta(meta) |
Member
There was a problem hiding this comment.
Can you make _validate_meta handle None instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Currently,
json_normalizeexhibits inconsistent behavior when using non-string keys in themetaparameter:meta=[12](withoutrecord_path) - incorrectly worksmeta=[12](withrecord_path) - correctly fails with TypeErrorThis inconsistency violates the principle of least surprise and contradicts the documented API.