BUG: ser.str.match with mismatched case/pat/flags #63108
+66
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Nov 15, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
+1 on this approach, it seems superior to me than having case or flags take precedence over the other. Docstring could use updated.
pandas/core/strings/accessor.py
Outdated
Comment on lines
1424
to
1427
| if case is lib.no_default: | ||
| if is_re(pat): | ||
| implicit_case = not bool(pat.flags & re.IGNORECASE) | ||
| case = True |
Member
There was a problem hiding this comment.
Should this be:
Suggested change
| if case is lib.no_default: | |
| if is_re(pat): | |
| implicit_case = not bool(pat.flags & re.IGNORECASE) | |
| case = True | |
| if case is lib.no_default: | |
| if is_re(pat): | |
| case = not bool(pat.flags & re.IGNORECASE) |
rhshadrach
requested changes
Nov 18, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Can you add a line in the whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.