Skip to content

IO/Stata: clarify unsupported-version error message (text-only change) #63082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Open

IO/Stata: clarify unsupported-version error message (text-only change) #63082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pandas/io/stata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,16 @@
WriteBuffer,
)

# Error shown when a version number was parsed but is not supported.
# Wording intentionally mentions “either not a valid Stata dataset or
# an unsupported version” to avoid confusing users when input is not a
# real .dta.
_version_error = (
"Version of given Stata file is {version}. pandas supports importing "
"versions 102, 103, 104, 105, 108, 110 (Stata 7), 111 (Stata 7SE), "
"113 (Stata 8/9), 114 (Stata 10/11), 115 (Stata 12), 117 (Stata 13), "
"118 (Stata 14/15/16), and 119 (Stata 15/16, over 32,767 variables)."
"This is either not a valid Stata dataset or a Stata dataset from a "
"version pandas does not support (detected: {version}). pandas "
"supports importing versions 105, 108, 111 (Stata 7SE), 113 (Stata "
"8/9), 114 (Stata 10/11), 115 (Stata 12), 117 (Stata 13), 118 (Stata "
"14/15/16), and 119 (Stata 15/16, over 32,767 variables)."
)

_statafile_processing_params1 = """\
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/io/test_stata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,3 +2620,13 @@ def test_ascii_error(temp_file, version):
df.to_stata(temp_file, write_index=0, version=version)
df_input = read_stata(temp_file)
tm.assert_frame_equal(df, df_input)


def test_stata_v117_prefix_with_unsupported_version_raises_version_error():
# _read_new_header reads 27 bytes, then the next 3 are the release digits
buf = io.BytesIO(b"<stata_dta><header><release>999</release>" + b"\x00" * 64)
with pytest.raises(
ValueError,
match=(r"either not a valid Stata dataset|does not support.*999"),
):
read_stata(buf)
Loading