GH1432 Partial resolution for some TODOs #1492
Open
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
reviewed
Nov 18, 2025
| def read_orc( | ||
| path: FilePath | ReadBuffer[bytes], | ||
| columns: list[HashableT] | None = None, | ||
| dtype_backend: DtypeBackend | _NoDefaultDoNotUse = "numpy_nullable", |
Contributor
There was a problem hiding this comment.
In 3.0 the default value will be switched from "numpy_nullable" to no_default. I think this can be confusing to users using the stable releases 2.x. What should we do @Dr-Irv ? Anyway, we can address this in a separate PR.
Comment on lines
+103
to
+104
| # TODO: pandas-dev/pandas-stubs#1432 mypy sees datetime.timedelta but pyright is correct | ||
| # check(assert_type(ts_np - ts, pd.Timedelta), pd.Timedelta) |
Contributor
There was a problem hiding this comment.
I see our __rsub__ is correct but mypy takes ts_np.__sub__ as a higher priority. This has happened a lot in Series and Index arithmetic. I think neither mypy nor pyright is correct, we should see Any here because of the discrepency. Do you have any suggestion to improve here, @Dr-Irv ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs intimestamps.pyi,timedeltas.pyiandorc.pyi#1432assert_type()to assert the type of any return valueResolution for: