Fix ENOTDIR handling in Config.from_file() with silent=True#5923
Closed
apoorvdarshan wants to merge 1 commit intopallets:mainfrom
Closed
Fix ENOTDIR handling in Config.from_file() with silent=True#5923apoorvdarshan wants to merge 1 commit intopallets:mainfrom
apoorvdarshan wants to merge 1 commit intopallets:mainfrom
Conversation
`from_pyfile()` correctly suppresses `ENOTDIR` when `silent=True`, but `from_file()` was missing it. This caused an `OSError` when a path component is a regular file instead of a directory (e.g. `~/.myapp` is a file and loading `~/.myapp/config.toml`).
Member
|
May I ask what made you open this PR (did an LLM tell you there is a bug? or did you actually encounter a problem yourself?), and whether you used AI for this or not? Because we closed a similar issue as "not planned" recently, and likewise the associated PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_pyfile()correctly suppresseserrno.ENOTDIRwhensilent=True, butfrom_file()was missing itOSErrorwhen a path component is a regular file instead of a directory (e.g.~/.myappis a file and loading~/.myapp/config.toml)errno.ENOTDIRto the silent error tuple, matchingfrom_pyfile()behaviorTest plan
test_config_enotdir_silent— creates a file where a directory is expected and confirmsfrom_file(..., silent=True)returnsFalseinstead of raising