Skip to content

Changed tempfile.NamedTemporaryFile mode to 'w' #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
H-Sorkatti wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Changed tempfile.NamedTemporaryFile mode to 'w' #3739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/click/_termui_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ def _tempfilepager(
# On Windows, NamedTemporaryFile cannot be opened by another process
# while Python still has it open, so we use delete=False and clean up manually
# rather than using a contextmanager here.
f = tempfile.NamedTemporaryFile(mode="wb", delete=False)
f = tempfile.NamedTemporaryFile(mode="w", delete=False)
try:
yield t.cast(t.BinaryIO, f), encoding, color
f.flush()
Expand Down