Sort help args to make them reproducible - #3728
Conversation
|
I don't think the set or this simple sort are correct. We probably want to apply some specific order, such as long options then short options, or preserve the order they were originally specified. @kdeldycke I think you added this (and maybe I suggested the set in review, can't remember)? What do you think? |
Ah yes, the So the fix is to replicate the arithmetics, but with order preserving lists/tuples. It sounds like something I solved 2 years ago in #2811 / 70c673d when I added a I will amend this PR with something in the same spirit to speed up the process and have it reach the upcoming 8.5.0 release. |
Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
accdfed to
047adef
Compare
|
Just made the changes, this PR is ready to be merged. |
get_help_option_names() uses a set which is not ordered.
The return value is used by mkdocs-click making the
mkdocs-doc package in Debian not reproducible:
https://reproduce.debian.net/all/unstable.html#mkdocs-doc