Improve logging when git diff fails
#1490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
esword
reviewed
Dec 1, 2025
gradle/.DS_Store
Outdated
esword
previously approved these changes
Dec 1, 2025
crogoz
reviewed
Dec 1, 2025
| Preconditions.checkState(process.exitValue() == 0, "Expected return code of 0"); | ||
|
|
||
| if (process.exitValue() != 0) { | ||
| throw new IllegalStateException("Expected return code of 0 but got " + process.exitValue() |
Contributor
There was a problem hiding this comment.
I'd use a RuntimeException here instead, IllegalStateException is more to signal an illegal state of the application
Contributor
Author
There was a problem hiding this comment.
Gotcha, i used illegalstate to maintain parity with the previous exception checkState throws, but a runtime exception does make more sense here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
When
git difffails, we don't tell the user the exit code and stderr/stdout, meaning the user has to dive in and debug.After this PR
==COMMIT_MSG==
Improve logging when
git difffails==COMMIT_MSG==
Possible downsides?