Support larger list of version and AWS API v4 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support larger list of version and AWS API v4
Author
|
This is a small problem with this PR. I will make a better version later. |
olikeys
reviewed
Nov 22, 2017
| s3DataContents = s3DataContents.concat(contents.DeleteMarkers); | ||
| if (data.IsTruncated) { | ||
| params.VersionIdMarker = contents.NextVersionIdMarker; | ||
| params.KeyMarker = contents.NextVersionIdMarker; |
There was a problem hiding this comment.
should this line not be
params.KeyMarker = contents.NextKeyMarker;
|
|
||
| s3 = new AWS.S3(); | ||
| s3 = new AWS.S3( | ||
| {signatureVersion: 'v4'} |
Contributor
There was a problem hiding this comment.
I was under the impression AWS SDK handles this automatically, although I may have missed something - can you explain why we need to specify the signatureVersion to v4?
| params.KeyMarker = contents.NextVersionIdMarker; | ||
| recursiveCall(params); | ||
| } else { | ||
| s3DataContents = s3DataContents.filter((elm) => { return elm.Size > 0 }) |
Contributor
There was a problem hiding this comment.
We cannot do this - this will remove items which need to be deleted.
Contributor
|
Sorry about the delay in reviewing. I've made some comments, and also fixed up tests to run on travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support larger list of version and AWS API v4