Improve consistency of Jira refs in spec patch naming and changelog#618
Improve consistency of Jira refs in spec patch naming and changelog#618antbob wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the LLM agent prompt templates for backporting and logging. In instructions_zstream.j2, it refines the instructions for extracting and renaming patch files containing Jira issue keys. In instructions.j2, it clarifies how to handle Jira references and packaging details when reusing source changelog messages. Feedback suggests improving the clarity of the backport instructions by explicitly using a regex pattern [A-Z]+-[0-9]+ instead of the <JIRA_ISSUE> placeholder to describe the Jira issue key pattern, avoiding logical contradictions when the template is rendered.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@lbarcziova @TomasTomecek i dunno if you guys need the patch naming changes in the main instructions as well (if that would be beneficial to you or not) but if you do then let me know and i'll add them there as well. |
TomasTomecek
left a comment
There was a problem hiding this comment.
Looks good to me.
WDYT @TomasKorbar @opohorel
As the title suggests these changes just improve Jira references in the spec file patch names and changelog entries when backporting. This is specifically to accommodate the older z-stream requirements. We have been running with these changes for a couple of weeks now and they seem to hold and do whats generally expected/accepted for older z-stream backports.