Skip to content

chore: don't evaluate skip masks in fetch after search#412

Open
forshev wants to merge 1 commit intomainfrom
411-dont-skip-ids-in-fetch-after-search
Open

chore: don't evaluate skip masks in fetch after search#412
forshev wants to merge 1 commit intomainfrom
411-dont-skip-ids-in-fetch-after-search

Conversation

@forshev
Copy link
Copy Markdown
Collaborator

@forshev forshev commented Apr 28, 2026

Description

Add bool field to store's fetch request to not evaluate skip masks in fetch after search since these ids are already masked

Fixes #411


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.47%. Comparing base (124d460) to head (547848e).

Files with missing lines Patch % Lines
frac/active_index.go 80.00% 0 Missing and 1 partial ⚠️
frac/sealed_index.go 80.00% 0 Missing and 1 partial ⚠️
fracmanager/proxy_frac.go 66.66% 1 Missing ⚠️
proxy/search/ingestor.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   71.40%   71.47%   +0.06%     
==========================================
  Files         219      219              
  Lines       16454    16460       +6     
==========================================
+ Hits        11749    11764      +15     
+ Misses       3834     3824      -10     
- Partials      871      872       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't evaluate skip masks in fetch after search

2 participants