Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 71.28% 71.19% -0.09%
==========================================
Files 210 210
Lines 15579 15618 +39
==========================================
+ Hits 11105 11120 +15
- Misses 3673 3698 +25
+ Partials 801 800 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkharms
approved these changes
Apr 2, 2026
| } | ||
| defer in.Close() | ||
|
|
||
| out, err := os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o666) |
Member
There was a problem hiding this comment.
Why write-only? I mean this is not a good default for a such generic function CopyFile.
| if err != nil { | ||
| return err | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
defer out.Close() instead of manually closing the file?
eguguchkin
requested review from
eguguchkin and
moflotas
and removed request for
eguguchkin
moflotas
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If WAL file is corrupted, then increment a metric and copy to a separate directory
.broken