acpi: adjust DSDT device order#1164
Open
lgfa29 wants to merge 1 commit into
Open
Conversation
Using a `DsdtGenerator` to generate the AML code for the PS2 keyboard in the v0 ACPI variant can cause its position in the DSDT table to be different from the original tables because the `DsdtGenerators` are read from a the devices `BTreeMap`, which also include the serial ports. Since the map key for serial ports is defined in the VM spec, it can cause the device order to change based on user-input, which is not desirible for the v0 as we hope to match the original tables as close as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a
DsdtGeneratorto generate the AML code for the PS2 keyboard in the v0 ACPI variant can cause its position in the DSDT table to be different from the original tables because theDsdtGeneratorsare read from a the devicesBTreeMap, which also include the serial ports.Since the map key for serial ports is defined in the VM spec, it can cause the device order to change based on user-input, which is not desirible for the v0 as we hope to match the original tables as close as possible.