Conversation
e86ad72 to
4d80f3b
Compare
|
The PR is now polished and the new Bazel CI checks pass on macOS + Ubuntu. I anticipate that there could be concerns about introducing a second build system that the core contributors are less familiar with, and the overheads that may be associated with that. A few thoughts:
If that sounds reasonable, I can add a few words to the README to set expectations accordingly, let me know. |
|
Gentle ping. If I'm reading the room correctly, I suspect "upstream" may currently have other priorities, and/or maybe there are concerns about the overhead of introducing a second build system (see my previous comment)? That's totally reasonable -- it would still be nice to get some brief feedback to set expectations. |
|
Hey @smolkaj. Sorry for the delay. I'm curios to know a bit more on the motivation behind this. For this repository itself, I don't see it turning into a more multi-language effort beyond Rust and P4. When there is a P4 dependency in Rust, the use_p4 macro is typically used (example). One of the primary reasons we built |
This PR adds support for building this project using Bazel. The PR also includes a CI check to ensure the build and tests pass using Bazel, to prevent regressions.
Why Bazel?
Cargo is fantastic for pure Rust codebases. Bazel shines for multi-language projects with cross-language dependencies.