[11/n] [meta] migrate rack IDs to typed UUIDs#10652
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
Looks like |
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Looks like bootstrap::server::tests::test_persistent_sled_agent_request_schema failed.
I believe this test is to catch any accidental breakage for the on-disk-serialized StartSledAgentRequests. In this case the schema change is wire-compatible, so I think it's fine to just EXPECTORATE=overwrite it?
| let addr = sled.address(); | ||
| Self { | ||
| rack_id, | ||
| rack_id: rack_id.into_untyped_uuid(), |
There was a problem hiding this comment.
I assume we only support generic Uuid in oximeter timeseries - is there any reason to push support for typed UUIDs down to that? (I can't think of one, if the only benefit is to drop these conversions when constructing something for oximeter to consume)
There was a problem hiding this comment.
IIRC @bnaecker mentioned that we can't push down typed UUIDs to Oximeter yet.
Yep. |
3 participants
Realized while working on this stack that we were still using untyped UUIDs for the rack UUID. Since we're going to be working on multirack soon, let's convert the UUID type over now.
Depends on: