Use hiffy/idol calls directly - #393
Merged
Merged
Conversation
labbott
marked this pull request as draft
July 15, 2026 18:41
Contributor
Author
|
maybe this PR will make be finally fix whatever the heck the HID API is doing on ubuntu |
labbott
force-pushed
the
built_in_humility
branch
from
July 23, 2026 13:10
abae7f8 to
42e1df5
Compare
labbott
force-pushed
the
built_in_humility
branch
3 times, most recently
from
August 11, 2026 18:26
9789476 to
45c1f5d
Compare
Calling out to the humility binary to use the `hiffy` interface has some rough edges, notably it's very difficult to parse out errors. Use humility directly via Rust interfaces instead. Humility currently requires libusb which may not be available on Illumos systems. This can be compiled out via the `hiffy` feature.
labbott
force-pushed
the
built_in_humility
branch
from
August 11, 2026 19:16
3b63913 to
329b511
Compare
labbott
changed the title
labbott
marked this pull request as ready for review
August 11, 2026 19:16
Collaborator
|
Thanks for fixing up the mutability thing @labbott. There's still some weirdness w/r/t the cargo features in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I played around with making this a library in humility and ran into a version dependency nightmare when I tried to use
attest_datain the library. I then had the humility library just do the raw bytes but at that point I wondered why I was wrapping anything in humility in the first place.This is the first time I'm really trying to use hiffy/idol outside the core humility binary so it's very much an experiment in what actually works