Skip to content

minor: fix extra space at the bottom of combobox options #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Jun 30, 2026
+5 −2
Merged

minor: fix extra space at the bottom of combobox options #3272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/ui/lib/Combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ const NO_MATCH_ITEM: ComboboxItem = {
}
const isNoMatch = (item: ComboboxItem | null) => item === NO_MATCH_ITEM

// HUI's virtualizer needs the scroll container to have a non-zero height
const ITEM_HEIGHT = 40
// HUI's virtualizer needs the scroll container to have a non-zero height.
// Must match the actual rendered row height (.ox-menu-item: text-sans-md +
// py-2 + 1px border ≈ 34px) or the panel min-height overshoots the content
// and leaves empty space at the bottom.
const ITEM_HEIGHT = 34
const MAX_PANEL_HEIGHT = 280

/** Convert an array of items with a `name` attribute to an array of ComboboxItems
Expand Down
Loading