-
Notifications
You must be signed in to change notification settings - Fork 0
🎯 Core Node Types and Naming Conventions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Curvenote Preview
|
tarleb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up from here 👍
I'd like to throw out there the idea of renaming Code to CodeListing, just because that seems like a nice name and would keep naming closer to HTML. But I also like the "blocks first" naming convention.
nokome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @rowanc1. Looking forward to implementing these and minting a new version of the oxa packages with them in it.
| - **Emphasis** | ||
| - **Strong** | ||
| - **Superscript** | ||
| - **Subscript** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also include Strikethrough/Strikeout and Underline. Although they are slightly more contentious.
|
|
||
| Excluding these nodes at this stage is a deliberate choice to keep the initial core small, stable, and easy to implement. | ||
|
|
||
| ## Naming Conventions and Design Trade-offs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent, well-considered, section. Thank you!
This opens up the initial nodes. I have opted not to talk about a document/root type yet (maybe a mistake?). I am hoping these are not controversial. The naming convention needs some review, I went back and forth and don't quite remember the conversations in November or where we landed.