Open
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mzner
force-pushed
the
feat/OCISDEV-790/add-full-ci-flag
branch
from
2e85e63 to
c2a9145
Compare
LukasHirt
requested changes
May 5, 2026
Collaborator
LukasHirt
left a comment
LukasHirt
left a comment
There was a problem hiding this comment.
In drone, we were using filterTestSuitesToRun.js to find what tests should run. If you find the current approach works better I am fine with not using that but I would:
- check whether the result is the same
- if it won't be used anymore, delete it
Also, if we go with this approach, the GH action needs to be whitelisted.
|
|
||
| check-tests-passed: | ||
| needs: [e2e-playwright] | ||
| needs: [build, e2e-playwright] |
Collaborator
There was a problem hiding this comment.
Is this change needed? Tests already wait for build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Open tasks: