[full-ci][tests-only] test: run tests in parallel#13657
Draft
anon-pradip wants to merge 6 commits intomasterfrom
Draft
[full-ci][tests-only] test: run tests in parallel#13657anon-pradip wants to merge 6 commits intomasterfrom
anon-pradip wants to merge 6 commits intomasterfrom
Conversation
671aadf to
cc57e41
Compare
bde5a25 to
4436173
Compare
|
07c303a to
c5e6ebf
Compare
68c0887 to
4fc8d4f
Compare
4fc8d4f to
1ffd292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Problem Statement
When running E2E tests with
fullyParallel: true, tests failed due to two categories of backend conflicts:Solution
Part 1: Worker-Aware Resource Naming
Each parallel worker now generates unique resource identifiers while test code stays readable.
world.ts— generates stable, cached IDs:alice→Alice-w0-abc123,sales→sales-w1-xyzworldis passed; group display names get a(workerIndex)suffix for UI matching; user display names are kept cleanplaywright.config.ts—fullyParallel: truewith configurable worker countPart 2: Auth and Identity Fixes (spaces tests)
Four specific bugs surfaced when enabling the spaces spec for parallel execution:
alice(doesn't exist on backend)api/token/utils.tsuser.idfirst, fall back touser.originalIdsetTokenkeyed byuser.id,getTokenbyuser.originalId— mismatchenvironment/token.tsoriginalId || idcreateUserstored under transformed ID, lookups used original — "user not found"api/graph/userManagement.tscreateUser/deleteUser/addUserToGroupall key byoriginalId || idworldwasn't passedsteps/api/api.tsworldtogetUserinuserHasAssignedRolesToUsersFiles Changed
playwright.config.tsfullyParallel: true, configurable workersworld.tsworkerIndex,testId,idCache, ID generatorstest.tsworkerIndex/testIdintoWorldenvironment/userManagement.tstypes.tsoriginalId?: stringtoUserenvironment/token.tssetToken/getTokenuseoriginalId || idapi/token/utils.tsapi/graph/userManagement.tsoriginalId || idsteps/api/api.tsworldfor role assignmentadminSettings.ts,groups/index.tsworldto group helpersBackward compatible — all transformations are gated on
worldbeing present; non-parallel test paths are unaffected.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: