Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for differentiating themes between regular mode and “vault mode” by introducing a mode field on themes and wiring vault detection into theme selection.
Changes:
- Extends the runtime account route to support an optional
/vaultscope segment. - Adds a
useVault()composable and filters selectable themes bymode(regularvsvault) in the theme store. - Adds an unreleased changelog entry documenting the new theme property.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/router/index.ts | Makes the account page route work under an optional /vault scope. |
| packages/web-runtime/src/components/Topbar/UserMenu.vue | Preserves the current scope param when linking to the account route. |
| packages/web-pkg/src/composables/vault/index.ts | Introduces vault-mode detection based on the current URL. |
| packages/web-pkg/src/composables/piniaStores/theme.ts | Adds mode to the theme schema and filters themes by vault vs regular mode. |
| changelog/unreleased/enhancement-add-theme-mode.md | Documents the new mode theme property and valid values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LukasHirt
force-pushed
the
feat/vault-theme
branch
2 times, most recently
from
3a756e8 to
708587f
Compare
Added a new property to the theme called `mode`. This property specifies whether the theme is suitable for regular mode or vault mode. Valid values are `regular` and `vault`.
LukasHirt
force-pushed
the
feat/vault-theme
branch
from
708587f to
230c84d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new property to the theme called
mode. This property specifies whether the theme is suitable for regular mode or vault mode. Valid values areregularandvault.Motivation and Context
A clearly separate theme can be used in vault mode to hint to the users that they are within such mode.
How Has This Been Tested?
Types of changes