Skip to content

feat: add vault and drive to breadcrumbs #13628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzner wants to merge 1 commit into
base: feat/OCISDEV-524/mode-switch
Choose a base branch
from
+2 −2
Open

feat: add vault and drive to breadcrumbs #13628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/views/spaces/GenericSpace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ const breadcrumbs = computed(() => {
if (isProjectSpaceResource(unref(space))) {
rootBreadcrumbItems.push({
id: uuidV4(),
text: $gettext('Spaces'),
text: unref(route).params.scope === 'vault' ? $gettext('Vault') : $gettext('Drive'),
Copy link
Collaborator

@LukasHirt LukasHirt Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been clarified whether we really need to include the Drive? Most instances will be deployed without vault and in such case this feels like unnecessary string.

Copy link
Contributor Author

@mzner mzner Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to check with David/Julian.

to: createLocationSpaces('files-spaces-projects'),
isStaticNav: true
})
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/views/spaces/Projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ const spacesHelpList = computed(() => {
const breadcrumbs = computed(() => {
return [
{
text: $gettext('Spaces'),
text: unref(route).params.scope === 'vault' ? $gettext('Vault') : $gettext('Drive'),
onClick: () => loadResourcesTask.perform(),
isStativNav: true
}
Expand Down