chore(deps): bump js-yaml from 4.1.1 to 5.1.0#218
Conversation
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Diff is manifest-only (package.json + package-lock.json); js-yaml is bumped 4.2.0 → 5.0.0 as a direct build dependency, no source/docs code changes. This is a major bump with real breaking changes (rewritten in TS, removed safeLoad/safeLoadAll/safeDump and DEFAULT_SCHEMA, Type API replaced by tags API, load() now throws on empty input) and it drops Node < 18.
Verdict: low-risk to merge provided this repo's CI docs-build job (and its Node version, must be ≥ 18) is green — that build is the real gate. js-yaml is used only by the Antora toolchain here, not by authored content, so a passing build is sufficient confidence. If CI is red, hold and check for a safeLoad/Type-API or Node-version regression.
|
@dependabot rebase |
|
Dependabot can't parse your package-lock.json. Because of this, Dependabot cannot update this pull request. |
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.1 to 5.1.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.1...5.1.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
ac87eae to
120004c
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Dependabot: js-yaml 4.1.1 → 5.1.0 (MAJOR bump) — LOW RISK, approve-with-nits.
Diff (+52/-6): package.json (^4.1.1→^5.1.0) and the top-level js-yaml lockfile node (→5.1.0, bin bin/js-yaml.js→bin/js-yaml.mjs). The extra +46 lines are not conflict-marker cleanup — they are three nested node_modules/@antora/{content-aggregator,playbook-builder,ui-loader}/node_modules/js-yaml entries pinning Antora's transitive js-yaml@4.1.1 now that the top-level dep moves to 5.x. Lockfile is valid JSON, conflict-free; Antora keeps its own 4.1.1, only the repo's direct dep goes to 5.x.
Usage check: one direct use — ext-antora/load-global-site-attributes.js: const yaml = require('js-yaml') + yaml.load(data) (line 104). CommonJS require + yaml.load still work in 5.x.
5.x breaking changes vs. this call site (parsed file: owncloud/docs/master/global-attributes.yml, fetched remotely):
- Empty input throws — file is non-empty; an empty fetch is caught by the extension's existing reject path.
- Default schema → CORE_SCHEMA — file uses only
true/false, no merge keys, no anchors/aliases, no\!\!tags, no YAML-1.1 implicit types (the one date-like value is a quoted string). - Flat ESM exports — not used (CommonJS API unaffected).
CI: Build documentation (runs yaml.load) and lint both pass.
CHANGELOG: n/a (repo has no changelog).
Nit (pre-existing): the attributes file is fetched from a remote master branch at build time — external dependency that can change independently. Not a blocker.
Bumps js-yaml from 4.1.1 to 5.1.0.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
f1e45cd5.1.0 released53b22beFix constructor coveragea1eaa2bFix quote style options and restore forceQuotes0532e7dAdd finalizers for immutable collection tags9f00b91tests: drop the rest of issues tests, move a small fraction of useful checks ...6be5d46tests: drop not actual or duplicating issue tests (covered in other places)a7c9766Fix !!pairs coverage75148bc5.0.0 released704b25dQuote document markers followed by whitespace42dea28Support complex !!pairs keys with realMapTag