chore(deps): remove dead Elasticsearch search-index builder and unused deps#1548
Merged
Merged
Conversation
…d deps The `ext-antora/generate-index.js` extension built an Elasticsearch search index, but it only ran when UPDATE_SEARCH_INDEX=true and the ELASTICSEARCH_* env vars were set. The docs site aggregator no longer sets these and no longer ships this extension (search moved to pagefind), so the code path is dead. Removing it lets us drop its sole-consumer dependencies, shrinking the transitive tree and the Dependabot attack surface: - drop @elastic/elasticsearch, cheerio, html-entities, lodash (only used by the indexer) and the unused asciidoctor direct dep (asciidoctor-kroki stays) - remove the generate-index.js extension and its site.yml reference - remove the never-referenced ext-asciidoc/ext-antora/generate-index.js duplicate - delete the orphan es-docker-compose.yml Elasticsearch dev-stack file js-yaml and asciidoctor-kroki are kept (still used). Verified the antora build still produces public/ output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
chore/drop-unused-elasticsearch-deps
branch
from
0f8cf11 to
cadecd8
Compare
kw-tmueller
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead Elasticsearch search-index builder (
ext-antora/generate-index.js) and the npm dependencies that only it consumed.Why
The indexer only executed when
UPDATE_SEARCH_INDEX=trueand theELASTICSEARCH_*env vars were set. The docs site aggregator no longer sets these and no longer ships this extension — search moved to pagefind — so the code path is dead. Carrying it kept a large transitive dependency tree (the elastic client, cheerio → parse5/entities, html-entities, lodash) that is a needless Dependabot attack surface.Changes
@elastic/elasticsearch,cheerio,html-entities,lodashfromdependencies(sole consumer was the indexer)asciidoctordirect dependency (never required;asciidoctor-krokiis separate and stays)ext-antora/generate-index.jsand its reference insite.ymlext-asciidoc/ext-antora/generate-index.jses-docker-compose.yml(Elasticsearch dev-stack file, referenced nowhere)package-lock.jsonjs-yamlandasciidoctor-krokiare kept — still in use.Verification
npm installsucceeds; lockfile no longer references the removed packages (the remaininglodash.merge/lodash.clonedeepare unrelated transitive deps)npm run antorastill produces fullpublic/HTML output (the removed extension was a no-op outside the indexing env). The remainingxref not foundwarnings are pre-existing —site.ymlsetsfailure_level: nonebecause the standalone build lacks the siblingdocs-*content sources.🤖 Generated with Claude Code