Skip to content

feat: edit a share on an oCIS server - #4978

Merged
joragua merged 10 commits into
masterfrom
feature/edit_file_share
Sep 29, 2026
Merged

joragua merged 10 commits into
masterfrom
feature/edit_file_share

Conversation

@joragua

@joragua joragua commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Related Issues

App: #4937

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Sep 15, 2026
@joragua joragua linked an issue Sep 15, 2026 that may be closed by this pull request
11 tasks
@joragua
joragua force-pushed the feature/edit_file_share branch 2 times, most recently from a31dfd0 to 88fd61b Compare September 18, 2026 11:32
@joragua
joragua marked this pull request as ready for review September 18, 2026 12:04
@joragua
joragua requested a review from a team as a code owner September 18, 2026 12:04
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
… oCIS server

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
…aSourceTest

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/edit_file_share branch from 6efa09c to 0b219d3 Compare September 24, 2026 10:14
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/edit_file_share branch from 8a6d397 to 066ddbf Compare September 25, 2026 11:14
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua requested a review from jesmrec September 28, 2026 08:49
@jesmrec

jesmrec commented Sep 28, 2026

Copy link
Copy Markdown
Member

Moving to QA 🚀

@jesmrec

jesmrec commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

(1) [FIXED]

  1. Enable Talkback
  2. In edit mode, click on Save

Current:

Talkback spells Create Share

Expected:

Talckback spells Save or Save share

Xiaomi Redmi 13, Android 15
0a6885fec

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua

joragua commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

(1) should be fixed in the commit 6885e6c

@jesmrec

jesmrec commented Sep 29, 2026

Copy link
Copy Markdown
Member

(1) fixed.

Approved!

@joragua
joragua merged commit 246ba49 into master Sep 29, 2026
11 checks passed
@joragua
joragua deleted the feature/edit_file_share branch September 29, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Sharing NG: edit share

2 participants