Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/4892
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Edge-to-edge multi-selection top bar

The multi-selection top bar now spans behind the system bars in landscape mode
on Android 15 and newer.

https://github.com/owncloud/android/issues/4892
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,17 @@ import android.widget.LinearLayout
import android.widget.TextView
import androidx.appcompat.app.AlertDialog
import androidx.appcompat.app.AppCompatActivity
import androidx.appcompat.R as AppCompatR
import androidx.appcompat.view.ActionMode
import androidx.appcompat.widget.SearchView
import androidx.browser.customtabs.CustomTabsIntent
import androidx.core.content.ContextCompat
import androidx.core.content.res.ResourcesCompat
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.view.isVisible
import androidx.core.view.updateLayoutParams
import androidx.core.view.updatePadding
import androidx.core.widget.doOnTextChanged
import androidx.drawerlayout.widget.DrawerLayout
import androidx.fragment.app.Fragment
Expand Down Expand Up @@ -200,6 +205,7 @@ class MainFileListFragment : Fragment(),
isFocusableInTouchMode = false
visibility = View.INVISIBLE
}
binding.root.post { adaptActionModeForInfiniteEdges() }
val inflater = requireActivity().menuInflater
inflater.inflate(R.menu.file_actions_menu, menu)
this@MainFileListFragment.menu = menu
Expand All @@ -209,6 +215,7 @@ class MainFileListFragment : Fragment(),
// Set gray color
val window = activity?.window
statusBarColor = window?.statusBarColor ?: -1
window?.statusBarColor = statusBarColorActionMode ?: statusBarColor!!

// Hide FAB in multi selection mode
toggleFabVisibility(false)
Expand Down Expand Up @@ -317,6 +324,33 @@ class MainFileListFragment : Fragment(),
}
}

private fun adaptActionModeForInfiniteEdges() {
val actionModeBar = requireActivity().findViewById<View>(
AppCompatR.id.action_mode_bar
) ?: return
(actionModeBar.parent as? ViewGroup)?.apply {
clipChildren = false
clipToPadding = false
}
ViewCompat.setOnApplyWindowInsetsListener(actionModeBar) { view, insets ->
val systemInsets = insets.getInsets(
WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()
)

view.updateLayoutParams<ViewGroup.MarginLayoutParams> {
leftMargin = -systemInsets.left
rightMargin = -systemInsets.right
}
view.updatePadding(
left = systemInsets.left,
right = systemInsets.right,
)

insets
}
ViewCompat.requestApplyInsets(actionModeBar)
}

override fun onCreateView(
inflater: LayoutInflater, container: ViewGroup?,
savedInstanceState: Bundle?
Expand Down Expand Up @@ -1675,4 +1709,3 @@ class MainFileListFragment : Fragment(),
}
}
}