Refine SecRequestBodyNoFilesLimit test cases to cover edge scenarios #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend and adjust existing tests for the SecRequestBodyNoFilesLimit directive in config-body_limits.json to ensure correct handling of edge boundary values.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Extend and adjust existing tests for the
SecRequestBodyNoFilesLimitdirective in config-body_limits.json to ensure correct handling of edge boundary values.Also fix the Content-Length of the requests. Note that an LF is added for each line in the body field. see
ModSecurity/test/regression/regression_test.cc
Line 51 in cebcde3
why
The existing tests do not cover edge boundary lengths. As a result, we cannot verify whether a request body whose length is exactly equal to
SecRequestBodyNoFilesLimitis accepted.references
None.