Open
Conversation
Member
|
@DmytroMitin Long follow up, I am no longer actively managing the project and haven't been for quite a while. This makes a lot of sense, and it looks like it's working. I am not even remembering the context, I recall there was some kind of special equality necessary to compare HLists, but not the specifics. Entirely possible I got something wrong. Any way I can help integrate and publish these changes? |
Author
|
@alexflav23 Feel free to publish any changes you consider relevant. Although I'm not sure whether those changes are binary compatible (MiMa). CI seems to be broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
==:==seems not to be needed.SingleGenericseems not to needReprandAux.Repris alwaysStore.It's important to define instances of macro-based type classes like
rather than
Otherwise
val tc = the[TC[A]]; implicitly[tc.Out =:= B]compiles butimplicitly[TC.Aux[A, B]]doesn't. Similarly, otherwisedb.users.store(user)compiles https://scastie.scala-lang.org/DmytroMitin/wEXiRryiSMaC1AiTYZVYZQ butdb.users.store[User, User :: HNil, UUID :: String :: String :: HNil, User :: HNil](user)doesn't https://scastie.scala-lang.org/DmytroMitin/wEXiRryiSMaC1AiTYZVYZQ/5 . Ability to specify type parameters can be useful for example for debugging implicits.It's a little weird that constraint
implicit gen: Generic[T]is put for the type classSingleGenericon method level rather than type-class instance level.Maybe
SingleGenericcan be ordinary type class (not macro-based)?