Skip to content

AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter#5811

Open
brianjaustin wants to merge 1 commit into
otwcode:masterfrom
brianjaustin:AO3-7160-unrevert
Open

AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter#5811
brianjaustin wants to merge 1 commit into
otwcode:masterfrom
brianjaustin:AO3-7160-unrevert

Conversation

@brianjaustin
Copy link
Copy Markdown
Member

This reverts commit 69d6268. It reintroduces #5699.

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7160

Purpose

Fixes the clipped autocomplete dropdown when assigning a pinch hitter on challenge maintainer assignments.

The dropdown was being clipped by ancestor elements using overflow: hidden (fieldset and form dl in 01-core.css).

Changes made:

  • Added maintainer-assignments class to the maintainer assignments fieldset.
  • Added scoped CSS override (overflow: visible) for that fieldset and its dl.index to allow the dropdown to render fully without affecting global styles.

Testing Instructions

Follow the reproduction steps in Jira (AO3-7160):
https://otwarchive.atlassian.net/browse/AO3-7160

Expected result:

  • The autocomplete dropdown is fully visible and not clipped.

Note: This is a visual/CSS fix and is not easily covered by existing automated tests.

Screenshots

Before:
ao3_7160_before

After:
ao3_7160_after

Credit

Name: Noah Bravo
Pronouns: they/them

This reverts commit 69d6268.

Co-authored-by: Noah Bravo <36118057+noahbravo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant