AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter#5811
Open
brianjaustin wants to merge 1 commit into
Open
AO3-7160 Fix clipped autocomplete dropdown when assigning a pinch hitter#5811brianjaustin wants to merge 1 commit into
brianjaustin wants to merge 1 commit into
Conversation
This reverts commit 69d6268. Co-authored-by: Noah Bravo <36118057+noahbravo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 69d6268. It reintroduces #5699.
Pull Request Checklist
AO3-1234 Fix thing)?Issue
https://otwarchive.atlassian.net/browse/AO3-7160
Purpose
Fixes the clipped autocomplete dropdown when assigning a pinch hitter on challenge maintainer assignments.
The dropdown was being clipped by ancestor elements using
overflow: hidden(fieldset and form dl in 01-core.css).Changes made:
maintainer-assignmentsclass to the maintainer assignments fieldset.overflow: visible) for that fieldset and itsdl.indexto allow the dropdown to render fully without affecting global styles.Testing Instructions
Follow the reproduction steps in Jira (AO3-7160):
https://otwarchive.atlassian.net/browse/AO3-7160
Expected result:
Note: This is a visual/CSS fix and is not easily covered by existing automated tests.
Screenshots
Before:

After:

Credit
Name: Noah Bravo
Pronouns: they/them