Skip to content

AO3-7291 Allow Wrangles to unassign multiple fandoms from themselves :)#5582

Open
not-varram wants to merge 3 commits intootwcode:masterfrom
not-varram:AO3-7291-Mass-Unassign-Fandoms
Open

AO3-7291 Allow Wrangles to unassign multiple fandoms from themselves :)#5582
not-varram wants to merge 3 commits intootwcode:masterfrom
not-varram:AO3-7291-Mass-Unassign-Fandoms

Conversation

@not-varram
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7291

Purpose

Adds bulk fandom unassignment from individual wrangler pages.

  • On /tag_wranglers/:id, show checkboxes and an Unassign Selected Fandoms button.
  • Visibility is limited to the wrangler whose page it is (and authorized admins).
  • Adds a new member endpoint to remove selected WranglingAssignment rows.
  • Preserves existing single-unassign behavior from the wranglers index page.

Testing Instructions

Use two existing tag wrangler accounts in the test environment:

  • Account A: the wrangler whose page will be edited
  • Account B: a different wrangler (for permission check)
  1. Log in as Account A.
  2. Go to /tag_wranglers and assign Account A to at least 3 fandoms.
  3. Go to /tag_wranglers/<account_a_login>.
  4. Confirm a checkbox column and Unassign Selected Fandoms button are visible.
  5. Select multiple fandoms and submit.
  6. Confirm flash notice: Wranglers were successfully unassigned!.
  7. Confirm selected fandom assignments were removed from Account A.

Permission check:

  1. Log in as Account B.
  2. Visit /tag_wranglers/<account_a_login>.
  3. Confirm Unassign Selected Fandoms is not visible.

Automated coverage added:

  • spec/controllers/tag_wranglers_controller_spec.rb
  • features/tags_and_wrangling/tag_wrangling_admin.feature (self bulk-unassign + denied for other wrangler)

Credit

varram (he/him)

@not-varram
Copy link
Contributor Author

By the way, I can also add the check boxes to allow bulk unassign in /tag_wranglers too, Just let me know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant