AO3-7291 Allow Wrangles to unassign multiple fandoms from themselves :)#5582
Open
not-varram wants to merge 3 commits intootwcode:masterfrom
Open
AO3-7291 Allow Wrangles to unassign multiple fandoms from themselves :)#5582not-varram wants to merge 3 commits intootwcode:masterfrom
not-varram wants to merge 3 commits intootwcode:masterfrom
Conversation
Contributor
Author
|
By the way, I can also add the check boxes to allow bulk unassign in /tag_wranglers too, Just let me know! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)?Issue
https://otwarchive.atlassian.net/browse/AO3-7291
Purpose
Adds bulk fandom unassignment from individual wrangler pages.
/tag_wranglers/:id, show checkboxes and an Unassign Selected Fandoms button.WranglingAssignmentrows.Testing Instructions
Use two existing tag wrangler accounts in the test environment:
/tag_wranglersand assign Account A to at least 3 fandoms./tag_wranglers/<account_a_login>.Wranglers were successfully unassigned!.Permission check:
/tag_wranglers/<account_a_login>.Automated coverage added:
spec/controllers/tag_wranglers_controller_spec.rbfeatures/tags_and_wrangling/tag_wrangling_admin.feature(self bulk-unassign + denied for other wrangler)Credit
varram (he/him)