Skip to content

AO3-7265 Remove index action and view for prompts#5578

Open
inggy wants to merge 2 commits intootwcode:masterfrom
inggy:AO3-7265
Open

AO3-7265 Remove index action and view for prompts#5578
inggy wants to merge 2 commits intootwcode:masterfrom
inggy:AO3-7265

Conversation

@inggy
Copy link

@inggy inggy commented Feb 10, 2026

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7265

Purpose

Removes the index action (and related view) for the prompts controller.

Credit

inggy (she/her)

@inggy
Copy link
Author

inggy commented Feb 10, 2026

This is what I see when testing locally. The JIRA says we should expect a 404 page which this doesn't look like. Just wanted to confirm this is expected in dev mode.

Screenshot 2026-02-09 162444

@sarken
Copy link
Collaborator

sarken commented Feb 10, 2026

Hi, inggy!

Thank you so much for this pull request. Someone will be along to give it a more thorough review it soon, but to answer your question, 404s on dev look a bit different from 404s on production. They're typically displayed as Routing Errors, with the same page style as the screen shot you've included. To get the right error, I think you might need to update config/routes.rb.

While this is waiting on a full review, I've updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

@inggy
Copy link
Author

inggy commented Feb 10, 2026

Hi sarken, thanks for the guidance. I'm relatively new to rails. I've updated routes.rb and got the following results.

Screenshot 2026-02-09 185026

I also tested with config.consider_all_requests_local = false and got this screenshot which I think is correct now.

Screenshot 2026-02-09 185046

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results in your screenshot are correct, so I'll mark this as approved!

Please let us know if you create a Jira account so we can get that updated for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants