AO3-7265 Remove index action and view for prompts#5578
AO3-7265 Remove index action and view for prompts#5578inggy wants to merge 2 commits intootwcode:masterfrom
Conversation
|
Hi, inggy! Thank you so much for this pull request. Someone will be along to give it a more thorough review it soon, but to answer your question, 404s on dev look a bit different from 404s on production. They're typically displayed as Routing Errors, with the same page style as the screen shot you've included. To get the right error, I think you might need to update config/routes.rb. While this is waiting on a full review, I've updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
sarken
left a comment
There was a problem hiding this comment.
The results in your screenshot are correct, so I'll mark this as approved!
Please let us know if you create a Jira account so we can get that updated for you.



Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7265
Purpose
Removes the index action (and related view) for the prompts controller.
Credit
inggy (she/her)