AO3-7222 This fix hides the Rename button when unauthorized#5519
AO3-7222 This fix hides the Rename button when unauthorized#5519Mangooomango wants to merge 1 commit intootwcode:masterfrom
Conversation
Only display Rename when policy(@user).can_change_username?
|
Hi, Mangooomango! Thank you so much for this pull request. Someone will be along to review it soon. I've updated the Jira issue status to In Review to make sure no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with both your account name and email address and we'll set up the permissions for you. Can you also edit your pull request comment so that it follows our pull request template? Namely, add the correct link to the Jira issue, add the purpose and remove the sections you don't fill. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
omerfaruk-pseud
left a comment
There was a problem hiding this comment.
Thank you! Can you also add automated tests in accordance to our coding standards? Since this changes the behaviour of a button, integration tests are needed so it can automatically check if it's displayed correctly.
Only display Rename when policy(@user).can_change_username?
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-XXXX (Please fill in issue number and remove this comment.)
Purpose
What does this PR do?
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.
You can remove this section if there are already full testing instructions in the Jira issue.
References
Are there other relevant issues/pull requests/mailing list discussions? If not, you can remove this section.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.