AO3-6964 Correctly Display Reply Notice on Admin Posts

[Nick-Raal]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6964

Purpose

This pull request changes the way the notice for moderated comments is displayed by checking the parent of the commentable object rather than the object itself.

References

Are there other relevant issues/pull requests/mailing list discussions? If not, you can remove this section.

Credit

niic (he/him)

[sarken]

I realize this is a draft and so you might not want review yet, but I left a suggestion about the test that might help with the failure.

However, it looks like features/comments_and_kudos/kudos.feature:70 is consistently failing even when I rerun the tests, so I think that might be a real issue. My first suggestion would be merging with master to see if that helps at all before spending too much time digging into it.

[sarken]

This should be more descriptive, like: "Scenario: Replying to a comment on an admin post with comment moderation shows a notice saying comments are moderated"

I haven't tested this, so it might need some tweaks, but I think we can make this whole test a lot shorter by creating an admin post with a comment and then enabling moderation:

Given the admin post "Generic Admin Post" with guest comments enabled
  And a guest comment on the admin post "Generic Admin Post"
When I am logged in as a "communications" admin
  And I go to the admin-posts page
  And I follow "Edit"
  And I check "Enable comment moderation"
  And I log out
  And I view the admin post "Generic Admin Post" with comments
  And I follow "Reply" # I looked at the issue and we don't need to actually leave a comment. The text we're testing should appear as soon as we open the reply form.
Then I should see "Comments on this news post are moderated." within #some-selector # I think we need to specify a selector here that's unique to the reply so we can be sure the test isn't just passing because the correct text appears on the form for leaving a top level comment. I'm pretty sure just checking for the text without the selector will pass even with the old, broken code.
  And I should not see "Comments on this work are moderated." # This isn't strictly necessary, but might not be a bad idea given the selector issue and the potential for the test to pass with the old code.

It would also avoid the issue with the test failing when looking for the Unreviewed Comments link.

[Bilka2]

Since this PR has been stalled for over a year, I've adopted the code at #5930