Skip to content

Conversation

@MaximilianHausen
Copy link
Contributor

Description

Adds a workaround for gitlab as an oicd provider. Gitlab returns a non-standard created_at field during authentication that needs to be discarded before passing it on to the database schema, just like what already happens for keycloak. Also adds a gitlab icon for the provider id "gitlab".

Checklist

  • I have read CONTRIBUTING.md in its entirety
  • I have performed a self-review of my own code
  • I have added unit tests to cover my changes
  • The last commit successfully passed pre-commit checks (It should be fine, but I skipped the pre-commit checks because they weirdly capitalized an unrelated multi-line comment later in the file)
  • Any AI code was thoroughly reviewed by me

// We strip them out before passing them on to the original adapter.
const {
['not-before-policy']: _notBeforePolicy,
'not-before-policy': _notBeforePolicy,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Keycloak logic being modified? I don't have a Keycloak instance so I have no way of testing if it breaks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because it triggered a no-useless-computed-key linter warning, but didn't verify it further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve now tested the keycloak sign-in with a local instance, and it still works.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks

@krokosik krokosik merged commit 6821614 into oss-apps:main Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants