Drop next-generation mariadb/rabbitmq/loadbalancer roles#2446
Open
berendt wants to merge 1 commit into
Open
Conversation
The "-ng" roles were only ever a tech preview intended to improve the regular mariadb, rabbitmq and loadbalancer plays and were never maintained intensively. Use the regular role names instead of the "-ng" variants: - Rename the "mariadb-ng" and "rabbitmq-ng" roles to "mariadb" and "rabbitmq" in MAP_ROLE2ROLE, keeping their dependency trees intact. - Drop the "loadbalancer-ng" special case in apply, so "loadbalancer" runs through the regular kolla path, and remove the now-unused kolla_action_ng handling and LOADBALANCER_PLAYBOOKS list. This complements the removal of the kolla-*-ng playbooks in osism/container-image-kolla-ansible#929. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christian Berendt <berendt@osism.tech>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stops referencing the
-ngroles and uses the regularmariadb,rabbitmqandloadbalancerroles instead.Why
The "next generation" plays were only ever a tech preview intended to improve the regular mariadb/rabbitmq/loadbalancer plays. They were never maintained intensively. Removing the client-side references avoids confusion with the actual roles.
This complements the removal of the
kolla-*-ngplaybooks in osism/container-image-kolla-ansible#929.Details
mariadb-ngandrabbitmq-ngroles tomariadbandrabbitmqinMAP_ROLE2ROLE, keeping their dependency trees intact.loadbalancer-ngspecial case inapply, soloadbalancerruns through the regular kolla path.kolla_action_nghandling and theLOADBALANCER_PLAYBOOKSlist (plus its tests).🤖 Generated with Claude Code