Repository navigation
GWSignal options: compatibility with older DAGs and calibration workers - #442
Merged
Merged
Conversation
Port of the O4c review fixes to #438 (oshaughn#217). - calibration_reweighting: parse the unquoted-key dictionary that DAGs built by older RIFT deliver ("{antisymmetric_modes_hm: True, ...}"); #438 raised ValueError there. Values are read as literals. - pseudo_pipe: when the GWSignal dictionary carries lmax_nyquist, also emit --use-gwsignal-lmax-nyquist for calibration. Workers older than gwsignal_extra_kwargs read only that flag. - rift.ini: 'gwsignal arguments' wins over 'arguments' when both are given, as before #438. - Tests for each; they fail on the rift_O4d tip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 11, 2026 23:32 — with 
GitHub Actions
Active
GitHub Actions
Active
oshaughnessy-junior
marked this pull request as ready for review
October 12, 2026 00:11
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
October 12, 2026 00:11 — with
GitHub Actions
Active
GitHub Actions
Active
![interhost-cross-review-canary-v2[bot]](https://avatars.githubusercontent.com/u/274802661?s=60&v=4){kind=small}
oshaughn
deployed
to
private-review-dispatch-rift
October 12, 2026 05:10 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the O4c compatibility fixes from oshaughn#217 to the #438 code on
rift_O4d.Submit side and worker containers are upgraded at different times. Three combinations broke after #438:
"{antisymmetric_modes_hm: True, ...}"with unquoted keys, and the new parser raised. The legacy parser is restored and now reads values as literals.lmax_nyquistonly from--use-gwsignal-lmax-nyquist. pseudo_pipe emits that flag again; the dictionary value wins, as in ILE.gwsignal argumentsandargumentsin a blueprint,gwsignal argumentswins again.Tests
rift_O4dtip.~/LVK/IR1/code_validation/o4c-gwsignal-options-pr217-20261011/on CIT.🤖 Generated with Claude Code