Skip to content

Use open::that for the PR URL #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReeseHatfield merged 1 commit into from
Jun 10, 2026
Merged

Use open::that for the PR URL #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cmd/deploy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ pub fn deploy(opts: DeployOptions) -> Result<(), Box<dyn Error>> {
println!("Add your presentation to oseda.net by making a Pull Request at:");
println!();
println!("{}", pull_request_url);

if open::that(pull_request_url.clone()).is_err() {
return Err(format!("Please visit {pull_request_url} in a browser and submit a pull-request by hand").into());
};

}
None => {
println!("Error: could not get github username");
Expand Down
Loading