tests: Fix bootc pxe testing #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cpio -c argument is different between Ubuntu and Fedora/CentOS/RHEL, on Ubuntu it means -H odc and on Fedora it is -H newc so let's remove any question of the type and pass '-H newc' It adds a diagnostic 'podman image inspect' after the bootc container is build, the output should help in tracking down exactly what container is being used. This also removes an unneeded argument (--installer-payload-ref) from the bib run, a result of copy and pasting other tests as a starting point.
Check the booted system to make sure it used the expected container reference. bootc status does not work with the PXE images, but rpm-ostree status does, so let's use that for now.
bcl
requested review from
croissanne,
lzap and
supakeen
and removed request for
a team
lzap
reviewed
Jan 24, 2026
| ["tar", "-C", tmpdir, "-x", "-f", pxe_tar_path]) | ||
| subprocess.check_call( | ||
| "echo rootfs.img | cpio -c --quiet -L -o > rootfs.cpio", shell=True, cwd=tmpdir) | ||
| "echo rootfs.img | cpio -H newc --quiet -L -o > rootfs.cpio", shell=True, cwd=tmpdir) |
Contributor
There was a problem hiding this comment.
And I dropped my suspicion because Fedora already uses... wait Ubuntu?!? :-)
Member
There was a problem hiding this comment.
The tests (these at least) run in GitHub actions which I think in our case runs on Ubuntu since we're not using our own container images for CI?
Contributor
There was a problem hiding this comment.
Yeah I am aware, it was just a lame joke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpio -c argument is different between Ubuntu and Fedora/CentOS/RHEL, on Ubuntu it means -H odc and on Fedora it is -H newc so let's remove any question of the type and pass '-H newc'
It adds a diagnostic 'podman image inspect' after the bootc container is build, the output should help in tracking down exactly what container is being used.
This also removes an unneeded argument (--installer-payload-ref) from the bib run, a result of copy and pasting other tests as a starting point.