-
Notifications
You must be signed in to change notification settings - Fork 435
feat: added a guide for the passkey integrations #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…le passkeys. Also tackled a bit of the web passkeys as well.
| The domain in your Associated Domains entitlement must exactly match the `rp.id` in your Kratos passkey configuration. The domain | ||
| must be accessible via HTTPS with a valid TLS certificate. The `apple-app-site-association` file must be served with | ||
| `Content-Type: application/json`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how we can for Ory Network. But maybe we can for selfhosted. The Apple and Android documentation does a good job of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think this is usable in production unless we host these assetlinks/app-site-associations for them as well. I am going to add a note to the feature PR that this will be required. I think I can add it to Kratos and maybe we start where it is a config thing. I will play with it this week.
Co-authored-by: Jonas Hungershausen <jonas.hungershausen@ory.sh>
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm,
a few style issues and sidebar is missing.
let me know if I can help with sidebar, im quite familiar with it.
only nit is that I would prefer the troubleshooting part to be a separate doc under https://www.ory.com/docs/category/troubleshooting and that the doc is maybe a bit overly verbose, but that is more a personal preference ;)
Co-authored-by: Vincent <vincent@ory.sh>
|
If you could help with the sidebar and feel free to split the troubleshooting to a different document for sure! |
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments