Skip to content

Conversation

@jhickmanit
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

…le passkeys. Also tackled a bit of the web passkeys as well.
Comment on lines +147 to +149
The domain in your Associated Domains entitlement must exactly match the `rp.id` in your Kratos passkey configuration. The domain
must be accessible via HTTPS with a valid TLS certificate. The `apple-app-site-association` file must be served with
`Content-Type: application/json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how we can for Ory Network. But maybe we can for selfhosted. The Apple and Android documentation does a good job of this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think this is usable in production unless we host these assetlinks/app-site-associations for them as well. I am going to add a note to the feature PR that this will be required. I think I can add it to Kratos and maybe we start where it is a config thing. I will play with it this week.

Co-authored-by: Jonas Hungershausen <jonas.hungershausen@ory.sh>
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Nov 26, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm,
a few style issues and sidebar is missing.
let me know if I can help with sidebar, im quite familiar with it.

only nit is that I would prefer the troubleshooting part to be a separate doc under https://www.ory.com/docs/category/troubleshooting and that the doc is maybe a bit overly verbose, but that is more a personal preference ;)

Co-authored-by: Vincent <vincent@ory.sh>
@jhickmanit
Copy link
Contributor Author

If you could help with the sidebar and feel free to split the troubleshooting to a different document for sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants