Skip to content

refactor(auth): retire legacy login modal #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beruro wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor(auth): retire legacy login modal #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/api/http/auth/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
export {
getLoginUrl,
completeLogin,
getCurrentUserInfo,
getUserInfoByAuthingId,
deleteGitHubAccount,
deleteGitLabAccount,
addGitHubClassicToken,
addGitLabClassicToken,
setUserAPIKey,
authApi,
} from "./login";

export {
getSupabaseAuthClient,
signInWithSupabase,
Expand All @@ -31,5 +18,3 @@ export {
type AuthState,
type TokenResponse as SecureTokenResponse,
} from "./secure";

export { default } from "./login";
138 changes: 0 additions & 138 deletions src/api/http/auth/login.ts
View file
Open in desktop

This file was deleted.

19 changes: 5 additions & 14 deletions src/modules/shared/layouts/GlobalModals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,7 @@ import { useAtomValue } from "jotai";
import React, { Suspense, useEffect, useState } from "react";

import { componentIssueModalOpenAtom } from "@src/store/ui/overlayAtom";
import { loginModalVisibleAtom } from "@src/store/ui/uiAtom";

const LoginModal = React.lazy(
() => import("@/src/scaffold/ModalSystem/variants/Login")
);
const ComponentIssueModalProvider = React.lazy(() =>
import("@src/modules/shared/DevTools/ComponentIssueModal").then((module) => ({
default: module.ComponentIssueModalProvider,
Expand Down Expand Up @@ -43,13 +39,8 @@ const ComponentIssueModalLoader: React.FC = () => {
return <ComponentIssueModalProvider />;
};

export const GlobalModals: React.FC = () => {
const loginModalVisible = useAtomValue(loginModalVisibleAtom);

return (
<Suspense fallback={null}>
{loginModalVisible && <LoginModal />}
<ComponentIssueModalLoader />
</Suspense>
);
};
export const GlobalModals: React.FC = () => (
<Suspense fallback={null}>
<ComponentIssueModalLoader />
</Suspense>
);
2 changes: 0 additions & 2 deletions src/scaffold/ModalSystem/component-modal-0129.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ Used extensively throughout the app for modals:

- `src/components/DeleteModal/index.tsx` - Used in delete modal
- `src/components/CreateBranchModal/index.tsx` - Used in create branch modal
- `src/components/LoginModal/index.tsx` - Used in login modal
- `src/components/GlobalModal/component/FormModal.tsx` - Used in form modal
- And many other components

Expand Down Expand Up @@ -363,7 +362,6 @@ interface ConfirmModalConfig {
The ModalSystem includes several specialized modal variants:

- `variants/QuickUpload/` - File upload modal
- `variants/Login/` - Login modal
- `variants/Rename/` - Rename modal
- `variants/AddFunds/` - Add funds modal
- `variants/ContentView/` - Content viewing modal
Expand Down
Loading
Loading