Add verify-new-library-version-compatibility.yml step for closing pre-release issues when full release is present #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-release issues when full release is present
vjovanov
approved these changes
Dec 3, 2025
| if [[ -z "$VERSION" ]]; then continue; fi | ||
| # Parse version | ||
| VERSION_REGEX="^([0-9]+(\.[0-9]+)*)(\.Final)?([-.](alpha[0-9]*|beta[0-9]*|rc[0-9]*|cr[0-9]*|m[0-9]+|ea[0-9]*|b[0-9]+|[0-9]+|preview)([-.].*)?)?$" |
Member
Author
There was a problem hiding this comment.
I moved the PRE_RELEASE_SUFFIX to be an env var, and then we reuse it when creating VERSION_REGEX.
If you meant reuse it from the gradle tasks where we use it, I don't believe we can, as we don't have a way to extract it to bash (and bash uses slightly different regex syntax).
| continue | ||
| fi | ||
| PRE_RELEASE_SUFFIX="(alpha[0-9]*|beta[0-9]*|rc[0-9]*|cr[0-9]*|m[0-9]+|ea[0-9]*|b[0-9]+|[0-9]+|preview)" |
Member
There was a problem hiding this comment.
These regexes should be in one place.
Member
Author
There was a problem hiding this comment.
PRE_RELEASE_SUFFIX is now moved to the env vars. PRE_RELEASE_REGEX is constructed only after VERSION_REGEX successfully matches, because we need the parsed base version before we can build the PRE_RELEASE_REGEX used to match issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces automatic closing of open GitHub pre-release version issues generated by automation, when the corresponding full release version becomes available.
The workflow step closes issues in two situations:
The changes to the workflow have been tested on a fork. Examples of both situations can be found here:
The new workflow step uses the same regex logic when looking for pre-release versions as it does in the
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java, just converted to abashcompatible regex.Fixes: #807