Skip to content

[GR-65714] Fix isolated waitpid subprocess tests #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 1 commit into from
May 11, 2026
+4 −4
Merged

[GR-65714] Fix isolated waitpid subprocess tests #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions graalpython/com.oracle.graal.python.test/src/tests/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2018, 2025, Oracle and/or its affiliates.
# Copyright (c) 2018, 2026, Oracle and/or its affiliates.
# Copyright (C) 1996-2017 Python Software Foundation
#
# Licensed under the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2
Expand All @@ -11,7 +11,7 @@
from subprocess import CalledProcessError
from tempfile import mkdtemp

POSIX_BACKEND_IS_JAVA = sys.implementation.name == "graalpy" and __graalpython__.posix_module_backend != 'java'
POSIX_BACKEND_IS_JAVA = sys.implementation.name == "graalpy" and __graalpython__.posix_module_backend() == 'java'

def test_os_pipe():
import os
Expand Down Expand Up @@ -122,6 +122,7 @@ def safe_decode(x):
print("===== stderr:")
print(safe_decode(e.stderr))
print("=============")
raise
finally:
if filename:
os.remove(filename)
Expand All @@ -137,8 +138,7 @@ def test_waitpid_group_child(self):
stdin=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
ps_list = 'not available'
if sys.implementation.name == "graalpy" and \\
and sys.platform.startswith("linux"):
if sys.implementation.name == "graalpy" and sys.platform.startswith("linux"):
ps_list = subprocess.check_output("ps", shell=True, text=True)
res = os.waitpid(0, 0)
msg = f"Spawned {p.pid=}, os.waitpid result={res}, output of ps:\\n{ps_list}"
Expand Down
Loading