[AI-FSSDK] [FSSDK-12368] Local Holdouts - Cleanup flag base setup and add includedRules and rule-level lookup#501
Open
[AI-FSSDK] [FSSDK-12368] Local Holdouts - Cleanup flag base setup and add includedRules and rule-level lookup#501
Conversation
Add Local Holdouts support to replace legacy flag-level holdouts with rule-level targeting. Changes: - Add includedRules field to Holdout model (replaces includedFlags/excludedFlags) - Add isGlobal property for global vs local holdout detection - Update HoldoutConfig mapping from flag-level to rule-level - Implement get_global_holdouts() and get_holdouts_for_rule() methods - Integrate local holdout evaluation in decision flow (per-rule, before audience/traffic) - Handle edge cases (missing field, empty array, invalid rule IDs, cross-flag targeting) - Add comprehensive unit tests for local holdouts - Update existing tests to use new API Quality Metrics: - Tests: 71/71 passing (100%) - Critical Issues: 0 - Warnings: 0 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Local Holdouts support for the Python SDK, replacing legacy flag-level holdout targeting (
includedFlags/excludedFlags) with rule-level targeting (includedRules).Related Ticket: FSSDK-12368
Changes
Data Model
included_rulesfield toHoldoutmodel (optional array of rule IDs)is_globalproperty (Truewhenincluded_rules is None)included_flags,excluded_flagsHoldout Configuration
HoldoutConfigfrom flag-level to rule-level mappingget_global_holdouts()- returns holdouts withincluded_rules == Noneget_holdouts_for_rule(rule_id)- returns holdouts targeting specific ruleDecision Flow
source="holdout",experiment_id,ruleKeyEdge Cases
included_rulesfield defaults toNone(global holdout)[]vsNonehandled correctly (empty = local with no rules, None = global)Testing
New Tests (11 comprehensive tests in
tests/test_local_holdouts.py)Updated Tests (60 existing tests)
included_flags/excluded_flagstoincluded_rulesis_globalpropertyQuality Metrics
Files Modified
optimizely/entities.py- Holdout model updatesoptimizely/project_config.py- Mapping and retrieval logicoptimizely/decision_service.py- Decision flow integrationoptimizely/helpers/types.py- Type definitionstests/test_local_holdouts.py- New comprehensive test suitetests/test_decision_service_holdout.py- API updatestests/test_config.py- Model updatesTest Plan
🤖 Generated with Claude Code