[FSSDK-12670] Include commonIdentifiers in identifyUser identifier count#631
Merged
Conversation
…identifyUser identifyUser() was checking identifier count before augmenting with commonIdentifiers (e.g., vuid set by android-sdk), causing valid identify events with fs_user_id + vuid to be dropped as single-identifier. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identifyUser()was checking the identifier count before augmenting withuserCommonIdentifiers(e.g., vuid set by android-sdk). This caused valid identify events withfs_user_id+vuidto be incorrectly dropped as single-identifier events.Changes
commonIdentifiersbefore the size check inidentifyUser()so vuid from common identifiers is countedJira Ticket
FSSDK-12670