Skip to content

[FSSDK-11986] upgrade Jackson serializer deprecated class #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+14 −10
Open

[FSSDK-11986] upgrade Jackson serializer deprecated class #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ded1129
fix Jackson Serializer deprecation
jaeopt Nov 12, 2025
a860eeb
change to temurin
jaeopt Nov 13, 2025
7d72e44
use zulu
jaeopt Nov 13, 2025
303d07f
jdk to 8,11
jaeopt Nov 13, 2025
abcf41a
use temurin, 11 and 17
jaeopt Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,17 @@ jobs:
strategy:
fail-fast: false
matrix:
jdk: [8, 9]
jdk: [11, 17]
optimizely_default_parser: [GSON_CONFIG_PARSER, JACKSON_CONFIG_PARSER, JSON_CONFIG_PARSER, JSON_SIMPLE_CONFIG_PARSER]
steps:
- name: checkout
uses: actions/checkout@v4

- name: set up JDK ${{ matrix.jdk }}
uses: AdoptOpenJDK/install-jdk@v1
uses: actions/setup-java@v4
with:
version: ${{ matrix.jdk }}
architecture: x64
java-version: ${{ matrix.jdk }}
distribution: 'temurin'

- name: Grant execute permission for gradlew
run: chmod +x gradlew
Expand Down
6 changes: 3 additions & 3 deletions core-api/src/main/java/com/optimizely/ab/event/internal/serializer/JacksonSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
*
* Copyright 2016-2017, 2019, Optimizely and contributors
* Copyright 2016-2017, 2019, 2025 Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -19,13 +19,13 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;

class JacksonSerializer implements Serializer {

private ObjectMapper mapper =
new ObjectMapper().setPropertyNamingStrategy(
PropertyNamingStrategy.SNAKE_CASE);
PropertyNamingStrategies.SNAKE_CASE);

public <T> String serialize(T payload) {
mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
Expand Down
4 changes: 2 additions & 2 deletions ...-api/src/test/java/com/optimizely/ab/event/internal/serializer/JacksonSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import com.fasterxml.jackson.databind.ObjectMapper;

import com.fasterxml.jackson.databind.PropertyNamingStrategy;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.optimizely.ab.event.internal.payload.EventBatch;

import org.junit.Test;
Expand All @@ -42,7 +42,7 @@ public class JacksonSerializerTest {
private JacksonSerializer serializer = new JacksonSerializer();
private ObjectMapper mapper =
new ObjectMapper().setPropertyNamingStrategy(
PropertyNamingStrategy.SNAKE_CASE);
PropertyNamingStrategies.SNAKE_CASE);


@Test
Expand Down
6 changes: 5 additions & 1 deletion java-quickstart/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ dependencies {
implementation project(':core-api')
implementation project(':core-httpclient-impl')

implementation group: 'com.google.code.gson', name: 'gson', version: gsonVersion
// implementation group: 'com.google.code.gson', name: 'gson', version: gsonVersion
implementation 'com.fasterxml.jackson.core:jackson-core:2.17.0'
implementation 'com.fasterxml.jackson.core:jackson-annotations:2.17.0'
implementation 'com.fasterxml.jackson.core:jackson-databind:2.17.0'

implementation group: 'org.apache.httpcomponents', name: 'httpclient', version: httpClientVersion
implementation group: 'org.apache.logging.log4j', name: 'log4j-api', version: log4jVersion
implementation group: 'org.apache.logging.log4j', name: 'log4j-core', version: log4jVersion
Expand Down