Skip to content

Conversation

@junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Nov 14, 2025

Summary

  • Tag variable fix
  • Added support for manual workflow dispatch with a required tag input, allowing users to specify a release tag when triggering the workflow manually. The workflow now resolves the tag from either the release event or the manual input and provides error messaging if no tag is available.
  • Renamed artifact outputs for each build job to clearly distinguish between unsigned-dlls-framework, unsigned-dlls-netstandard16, and unsigned-dlls-netstandard20, making it easier to track and download specific DLLs for each target. [1] [2] [3]

Test plan

Issues

  • FSSDK-12076

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the C# release workflow to support manual workflow dispatch and improves artifact management. The key improvement is fixing the tag variable resolution by properly passing it through step outputs instead of relying on environment variables, which resolves FSSDK-12076.

  • Added manual workflow dispatch support with a required tag input parameter for flexible release triggering
  • Fixed tag variable resolution by outputting it from the step instead of directly from environment variable
  • Renamed artifact outputs to distinguish between framework targets (unsigned-dlls-framework, unsigned-dlls-netstandard16, unsigned-dlls-netstandard20)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing the tag propogation. One comment below for consideration.

uses: actions/upload-artifact@v4
with:
name: unsigned-dlls
name: unsigned-dlls-framework
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I kept the unsigned binaries together to provide a single upload for signing. If you see this is better, I do not object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to recent changes in "upload artifact" action its not possible to upload same name artifact multiple times.

I was getting Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run and forced to do it this way.

The details of the breaking changes could be found here - https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

@junaed-optimizely junaed-optimizely merged commit 0db9aab into master Nov 14, 2025
16 of 17 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-11956-csharp-release-fixed branch November 14, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants