[FSSDK-12072] Integrate Redis Streams into agent #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit integrates Redis Streams for persistent notification delivery from v4.3.0-beta.1 with the existing CMAB Redis cache support in master. Features Added: - Redis Streams implementation for notification synchronization with persistent message delivery, automatic retries, consumer groups, and configurable batching - Flexible Redis authentication utility supporting auth_token, redis_secret, and password fields with environment variable fallback - Applied flexible auth pattern to all Redis clients: ODP cache, UPS, CMAB cache, and synchronization pubsub - Configurable CMAB prediction endpoint via config or environment variable Changes: - Added pkg/syncer/pubsub/redis_streams.go and comprehensive tests - Added pkg/utils/redisauth for flexible password authentication - Updated all Redis clients (ODP, UPS, CMAB) with UnmarshalJSON for auth - Updated config.yaml with Redis Streams parameters and auth_token field - Updated CHANGELOG.md with [Unreleased] section documenting new features - Updated CI workflow to use Redis 6 and added Redis to test-coverage job - Added docs/redis-streams.md with complete Redis Streams documentation Configuration: - CMAB configuration remains under client.cmab section - Redis Streams enabled via synchronization.notification.default - All Redis clients support auth_token, redis_secret, password fields - Environment variables: REDIS_PASSWORD, REDIS_ODP_PASSWORD, REDIS_UPS_PASSWORD, REDIS_CMAB_PASSWORD Testing: - All existing tests pass - Added 5 new auth tests for CMAB Redis cache - Redis Streams includes 18 comprehensive tests - redisauth utility includes 14 tests covering all scenarios Both features coexist without conflicts - Redis Streams uses STREAM data type for messaging while CMAB cache uses STRING type for key-value storage.
jaeopt
requested changes
Nov 14, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! A few suggestions to be considered.
jaeopt
requested changes
Nov 20, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Love it. A few more suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit integrates Redis Streams for persistent notification delivery from v4.3.0-beta.1 with the existing CMAB Redis cache support in master.
Also adds check if redis version is 5 or less. If less agent uses redis and pubsub, if 5 or greater it uses redis streams.
Features Added:
Changes:
Configuration:
Testing:
Both features coexist without conflicts - Redis Streams uses STREAM data type for messaging while CMAB cache uses STRING type for key-value storage.
Issues