-
Notifications
You must be signed in to change notification settings - Fork 16
fix(wasm): preserve dyn=1 when deduplicating edges with same source/target/kind/conf #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
5bed41b
fix(native): add RES-3 reflection resolution to Rust call resolver fo…
carlos-alm 1b82c36
fix(native): kotlin callable-ref prefers class method; suppress spuri…
carlos-alm 2c63d06
fix(wasm): preserve dyn=1 when deduplicating edges with same source/t…
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a PTS edge is upgraded in-place to a direct-call edge with
dyn=0(lines 1283–1294), the key is moved fromptsEdgeRowstoseenCallEdgesbut is never written intodynZeroEdgeRows. If a subsequentdyn=1+dynamicKindcall arrives for the same source/target pair,dynZeroEdgeRows.get(edgeKey)returnsundefinedand the upgrade todyn=1is silently skipped, leaving the edge asdyn=0. The decorator case described in the PR (both calls resolved through the direct-call path) won't hit this, but a target that first appears via a PTS alias and later via a bare decorator would remain misclassified.